Skip to content

[Az.BillingBenefits] Update generation tool version: autorest.powershell V3 -> V4 #27466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2025

Conversation

lijinpei2008
Copy link
Contributor

…l v3->v4

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 marked this pull request as ready for review April 11, 2025 12:35
variant: ^(Create|Update)(?!.*?(Expanded|JsonFilePath|JsonString))
remove: true
- where:
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrder$|^ValidateViaIdentitySavingsPlanOrderExpanded$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge validate* variants with the first directive by adding something like Create|Update|Validate

@dolauli dolauli self-assigned this Apr 16, 2025
remove: true
- where:
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrder$|^ValidateViaIdentitySavingsPlanOrderExpanded$
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrderExpanded$|^ElevateViaIdentity$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to remove ^ValidateViaIdentitySavingsPlanOrderExpanded$|^ElevateViaIdentity$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the cmdlets “Invoke-AzBillingBenefitsElevateSavingPlanOrder”, “Invoke-AzBillingBenefitsSavingsPlanPurchaseValidation” and “Invoke-AzBillingBenefitsSavingsPlanUpdateValidation” which are mainly part of the syntax in “XXXViaIdentity”.
This is because these three cmdlets now generate syntax that supports “ValidateViaJsonFilePath”, “ValidateViaJsonString”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the cmdlets “Invoke-AzBillingBenefitsElevateSavingPlanOrder”, “Invoke-AzBillingBenefitsSavingsPlanPurchaseValidation” and “Invoke-AzBillingBenefitsSavingsPlanUpdateValidation” which are mainly part of the syntax in “XXXViaIdentity”.
This is because these three cmdlets now generate syntax that supports “ValidateViaJsonFilePath”, “ValidateViaJsonString”.

@dolauli dolauli merged commit 86c08bb into main Apr 18, 2025
12 checks passed
@dolauli dolauli deleted the jinpei/main/BillingBenefits-v4 branch April 18, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants