-
Notifications
You must be signed in to change notification settings - Fork 4k
[Az.BillingBenefits] Update generation tool version: autorest.powershell V3 -> V4 #27466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
variant: ^(Create|Update)(?!.*?(Expanded|JsonFilePath|JsonString)) | ||
remove: true | ||
- where: | ||
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrder$|^ValidateViaIdentitySavingsPlanOrderExpanded$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge validate* variants with the first directive by adding something like Create|Update|Validate
remove: true | ||
- where: | ||
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrder$|^ValidateViaIdentitySavingsPlanOrderExpanded$ | ||
variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$|^ValidateViaIdentitySavingsPlanOrderExpanded$|^ElevateViaIdentity$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to remove ^ValidateViaIdentitySavingsPlanOrderExpanded$|^ElevateViaIdentity$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the cmdlets “Invoke-AzBillingBenefitsElevateSavingPlanOrder”, “Invoke-AzBillingBenefitsSavingsPlanPurchaseValidation” and “Invoke-AzBillingBenefitsSavingsPlanUpdateValidation” which are mainly part of the syntax in “XXXViaIdentity”.
This is because these three cmdlets now generate syntax that supports “ValidateViaJsonFilePath”, “ValidateViaJsonString”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the cmdlets “Invoke-AzBillingBenefitsElevateSavingPlanOrder”, “Invoke-AzBillingBenefitsSavingsPlanPurchaseValidation” and “Invoke-AzBillingBenefitsSavingsPlanUpdateValidation” which are mainly part of the syntax in “XXXViaIdentity”.
This is because these three cmdlets now generate syntax that supports “ValidateViaJsonFilePath”, “ValidateViaJsonString”.
…l v3->v4
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.